Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for expire command #35

Merged
merged 3 commits into from
May 6, 2024
Merged

feat: adds support for expire command #35

merged 3 commits into from
May 6, 2024

Conversation

eaddingtonwhite
Copy link
Member

No description provided.

cprice404
cprice404 previously approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than I don't understand why the return type is changing

@eaddingtonwhite eaddingtonwhite merged commit 60ae57b into main May 6, 2024
12 checks passed
@eaddingtonwhite eaddingtonwhite deleted the feat/adds-expire-cmd branch May 6, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@malandis malandis Awaiting requested review from malandis

@rishtigupta rishtigupta Awaiting requested review from rishtigupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaddingtonwhite @cprice404